From ca1ba182563b41fe7a4dbffc5308cdd5318833d6 Mon Sep 17 00:00:00 2001 From: Keir Fraser Date: Fri, 28 May 2010 09:25:34 +0100 Subject: [PATCH] xl: Move "extern" declarations to xl.h Declarations (as opposed to definitions) of external objects should not appear in .c files. Signed-off-by: Ian Jackson --- tools/libxl/xl.c | 3 --- tools/libxl/xl.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c index 82ab873a43..77eaa7b087 100644 --- a/tools/libxl/xl.c +++ b/tools/libxl/xl.c @@ -31,9 +31,6 @@ #include "libxl_utils.h" #include "xl.h" -extern struct libxl_ctx ctx; -extern int logfile; - void log_callback( void *userdata, int loglevel, const char *file, int line, const char *func, char *s) diff --git a/tools/libxl/xl.h b/tools/libxl/xl.h index faf784ae8b..450a12ff2b 100644 --- a/tools/libxl/xl.h +++ b/tools/libxl/xl.h @@ -74,4 +74,7 @@ void help(char *command); extern struct cmd_spec cmd_table[]; extern int cmdtable_len; +extern struct libxl_ctx ctx; +extern int logfile; + #endif /* XL_H */ -- 2.30.2